Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: improvements to developers documentation #732

Merged
merged 14 commits into from
Nov 30, 2024

Conversation

Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented Nov 18, 2024

Our development documentation really needs to be updated.
The last major additions to these pages were done more than 3 years ago.

I have re-strucctured the dev docs pages, but I'd appreciate if we could split these pages among our team of developers so we can have a more diverse point of view throughout our documentation.

These are the pages that still needs to be finished and reviewed :

  • setting_up.rst
  • Running RocketPy as a Developer <rocketpy_as_developer.rst>
  • Your First Pull Request (PR) <first_pr.rst>
  • Solving git conflicts <conflicts.rst>
  • Style Guide <style_guide>
  • Testing Guidelines <testing.rst>
  • RocketPy with Docker <docker.rst>
  • Building the Documentation <build_docs.rst>
  • Pro Tips <pro_tips.rst>

@Gui-FernandesBR Gui-FernandesBR self-assigned this Nov 20, 2024
@Gui-FernandesBR Gui-FernandesBR added the Docs Docs and examples related label Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.03%. Comparing base (bf5d4f5) to head (8bfadbc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
+ Coverage   75.97%   76.03%   +0.05%     
==========================================
  Files          99       94       -5     
  Lines       11255    10981     -274     
==========================================
- Hits         8551     8349     -202     
+ Misses       2704     2632      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR mentioned this pull request Nov 20, 2024
7 tasks
docs/development/conflicts.rst Outdated Show resolved Hide resolved
docs/development/conflicts.rst Outdated Show resolved Hide resolved
docs/development/conflicts.rst Outdated Show resolved Hide resolved
docs/development/style_guide.rst Outdated Show resolved Hide resolved
docs/development/setting_up.rst Outdated Show resolved Hide resolved
docs/development/setting_up.rst Outdated Show resolved Hide resolved
docs/development/setting_up.rst Outdated Show resolved Hide resolved
docs/development/first_pr.rst Outdated Show resolved Hide resolved
docs/development/pro_tips.rst Outdated Show resolved Hide resolved
@Gui-FernandesBR Gui-FernandesBR marked this pull request as ready for review November 30, 2024 03:34
@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner November 30, 2024 03:34
Copy link
Member Author

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work,

Than you so much for your contribution, @phmbressan , @Lucas-Prates @juliomachad0 !!

@Gui-FernandesBR Gui-FernandesBR merged commit e50d646 into master Nov 30, 2024
2 of 7 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the doc/update-development-documentation branch November 30, 2024 03:46
Gui-FernandesBR added a commit that referenced this pull request Nov 30, 2024
* DOC: improvements to developers documentation

* MNT: git rename a few files from the root directory

* DOC: more upgrades to development docs

* DEV: create script to delete local branches that no longer exist on remote

* DOC: I followed the step by step, looked at other parts of the documentation, and didn't find anything to correct or improve. I think it's fine as it is. I added a model to requirements.txt, which was missing when I ran the make html command.

* DOC: Update developer docs on sphinx building.

* DOC: Clarify testing structure on testing docs.

* DOC: Re-run docs requirements freeze.

* DOC: Introduce Conflicts Guideline and update First PR.

* DOC: fixing typos on development docs.

* DOC: Solve review comments of dev docs.

* DOC: final touches to developers documentation

* DOC: update cSpell configuration to enable additional file types

* DEV: move docker ignore file

---------

Co-authored-by: Julio Machado <[email protected]>
Co-authored-by: Pedro Bressan <[email protected]>
Co-authored-by: Lucas de Oliveira Prates <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Docs and examples related
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants