Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: updates workflows to include python 3.13 #719

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented Nov 2, 2024

with also a few other additions

@Gui-FernandesBR
Copy link
Member Author

@phmbressan apparently we cannot support python 3.13 yet ? Tests are failling.

I will turn this PR into a draft

@Gui-FernandesBR Gui-FernandesBR marked this pull request as draft November 2, 2024 00:08
@phmbressan
Copy link
Collaborator

phmbressan commented Nov 2, 2024

apparently we cannot support python 3.13 yet ? Tests are failling.

I will turn this PR into a draft

When I tested I ran the standard test suite, forgot about the doctest. The MacOS pytest (unit tests) seems to be fine, which is good news.

I will check if there is anything we can do to get the same results from the doctests as before, but it seems to be a numerical precision change.

@phmbressan
Copy link
Collaborator

phmbressan commented Nov 8, 2024

Locally, the same doctest is passing fine on Linux with 3.13. I believe we should round the values or change the test, since the difference is at the limit of numerical precision. Hard to do that with a "simple one liner" for the doctest.

@phmbressan phmbressan marked this pull request as ready for review November 8, 2024 16:21
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.03%. Comparing base (a902adf) to head (a7299c6).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #719      +/-   ##
===========================================
+ Coverage    75.96%   76.03%   +0.06%     
===========================================
  Files           99       94       -5     
  Lines        11258    10981     -277     
===========================================
- Hits          8552     8349     -203     
+ Misses        2706     2632      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR merged commit b838d53 into develop Nov 8, 2024
18 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the dev/support-python-313 branch November 8, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants