-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Free-Form Fins #694
Merged
Merged
ENH: Free-Form Fins #694
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0c8b389
ENH: add free form fins file
MateusStano fe31262
ENH: free form fins plots and prints
MateusStano 9a02ef8
ENH: add free form fins to rocket
MateusStano 3d2880f
ENH: update init files
MateusStano 3845316
MNT: isort
MateusStano 2869e91
MNT: improve overall evaluate_geom
MateusStano d2926c7
DOC: minor improvement to docs
MateusStano d37a3ab
MNT: lint
MateusStano 4ef3d0b
TST: add tests
MateusStano a5910f7
BUG: remove division by zero possibility
MateusStano 49cc5e1
MNT: remove unecessary comment
MateusStano 62b9ea9
DOC: fix draw plot title
MateusStano 879bba8
DOC: remove unused attributes
MateusStano bff7ecb
ENH: remove unecessary multiplication from opr
MateusStano ca460b8
ENH: add last line for fin plot
MateusStano 230e884
Merge branch 'enh/free-form-fins' of https://github.com/RocketPy-Team…
MateusStano 8caeee8
Merge branch 'enh/generic-surfaces' into enh/free-form-fins
MateusStano 81ee0d6
Merge branch 'enh/generic-surfaces' into enh/free-form-fins
MateusStano 378a4f9
MNT: flake
MateusStano e240163
Merge branch 'enh/free-form-fins' of https://github.com/RocketPy-Team…
MateusStano 502379e
MNT: isort
MateusStano 49abe78
DOC: improve shape point docs
MateusStano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,7 @@ | |
Components, | ||
EllipticalFins, | ||
Fins, | ||
FreeFormFins, | ||
GenericSurface, | ||
LinearGenericSurface, | ||
NoseCone, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ | |
AirBrakes, | ||
EllipticalFins, | ||
Fins, | ||
FreeFormFins, | ||
GenericSurface, | ||
LinearGenericSurface, | ||
NoseCone, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
from rocketpy.rocket.aero_surface.fins.elliptical_fins import EllipticalFins | ||
from rocketpy.rocket.aero_surface.fins.fins import Fins | ||
from rocketpy.rocket.aero_surface.fins.free_form_fins import FreeFormFins | ||
from rocketpy.rocket.aero_surface.fins.trapezoidal_fins import TrapezoidalFins |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The draw method is not closing the fin draw when the last point is different than the initial point, as shown in the figure below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are we going to close it? linearly? we should provide an example (in a future PR maybe) showing case when the fin is set at a non-planar surface. for example when the fins are placed on the tail/transition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I assumed that the Fin is defined by a closed polygon. Indeed, the documentation states that "the last point should be the first one." So, if the user forgot to make sure the last point is the first one, we either should raise an error or just close it ourselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model assumes that it is closed linearly. I will add the last line in the plot as well