Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC : Halcyon Flight Example #681

Merged
merged 18 commits into from
Sep 8, 2024
Merged

DOC : Halcyon Flight Example #681

merged 18 commits into from
Sep 8, 2024

Conversation

LUCKIN13
Copy link
Contributor

@LUCKIN13 LUCKIN13 commented Sep 6, 2024

Pull request type

  • ReadMe, Docs and GitHub updates

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Description

Added files for Halcyon flight example from Aerospace Team Graz.

Additional Information

Seems like the data for the atmospheric model is not equal to the registered in the flight simulation before the launch.

@LUCKIN13 LUCKIN13 requested a review from a team as a code owner September 6, 2024 19:06
@LUCKIN13 LUCKIN13 changed the base branch from master to develop September 6, 2024 22:15
@LUCKIN13 LUCKIN13 changed the title DOC / Halcyon Flight Example DOC : Halcyon Flight Example Sep 6, 2024
@LUCKIN13 LUCKIN13 changed the title DOC : Halcyon Flight Example DOC : Halcyon/Cavour Flight Example Sep 7, 2024
@LUCKIN13 LUCKIN13 changed the title DOC : Halcyon/Cavour Flight Example DOC : Halcyon Flight Example Sep 7, 2024
@Gui-FernandesBR
Copy link
Member

Great work, @LUCKIN13 !!

I've upload the .nc file that will allow us to simulate all the flights for the EuRoC 2023. I think it is better to use these data rather than relying on Windy. I downloaded the data from Copernicus (ECMWF) server earlier this year, and it is the same file used to create the EuRoC 2023 post-flight report.

@Gui-FernandesBR Gui-FernandesBR added the Docs Docs and examples related label Sep 8, 2024
@Gui-FernandesBR
Copy link
Member

I think in this case it is worth it to add the second plot as well. Can you give it a try, @LUCKIN13 ? Now you should be able to make the GNSS data comparison using the .nc file

image

@LUCKIN13
Copy link
Contributor Author

LUCKIN13 commented Sep 8, 2024

Thanks for your input @Gui-FernandesBR! Already added the latitude and longitude plots and they look great when compared to the reality. However, the descent phase of the flight seems to happen quicker.
I triple checked all the parameters and it's all equal to the ones used in the last simulation.

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition to our example gallery!

@Gui-FernandesBR Gui-FernandesBR merged commit 15de215 into develop Sep 8, 2024
1 check passed
@Gui-FernandesBR Gui-FernandesBR deleted the doc/flight-examples branch September 8, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Docs and examples related
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants