Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix the Frequency Response plot of Flight class #653

Merged
merged 3 commits into from
Aug 18, 2024

Conversation

Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented Aug 18, 2024

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

output_before

New behavior

output_after

Breaking change

  • No

Additional information

  • I noticed it was just a matplotlib plotting matter, not a problem with the calculations.

@Gui-FernandesBR Gui-FernandesBR linked an issue Aug 18, 2024 that may be closed by this pull request
@Gui-FernandesBR Gui-FernandesBR merged commit e81970b into develop Aug 18, 2024
5 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the fix/frequency-plot-flight-class branch August 18, 2024 13:07
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.94%. Comparing base (aa0673a) to head (7e2c6bf).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #653      +/-   ##
===========================================
+ Coverage    75.75%   75.94%   +0.19%     
===========================================
  Files           81       85       +4     
  Lines         9820    10082     +262     
===========================================
+ Hits          7439     7657     +218     
- Misses        2381     2425      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

juliomachad0 pushed a commit that referenced this pull request Aug 24, 2024
* BUG: fix the Frequency Response plot of Flight class
* DEV: adds #653 to CHANGELOG
* ENH: improves max_omega3 calculation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

ENH: Implement time-frequency analysis methods
1 participant