Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Refactor Parallel MonteCarlo and Stochastic Seeding #649

Merged
merged 7 commits into from
Aug 5, 2024

Conversation

phmbressan
Copy link
Collaborator

Pull request type

  • Code maintenance (refactoring, formatting, tests)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Enter text here...

New behavior

Enter text here...

Breaking change

  • Yes
  • No

Additional information

Enter text here...

@phmbressan phmbressan added the Monte Carlo Monte Carlo and related contents label Aug 3, 2024
@phmbressan phmbressan added this to the Release v1.X.0 milestone Aug 3, 2024
@phmbressan phmbressan self-assigned this Aug 3, 2024
@phmbressan phmbressan requested a review from a team as a code owner August 3, 2024 17:33
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 29.26829% with 87 lines in your changes missing coverage. Please review.

Project coverage is 74.93%. Comparing base (049276d) to head (26f692e).

Files Patch % Lines
rocketpy/simulation/monte_carlo.py 21.62% 87 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           enh/parallel_montecarlo     #649      +/-   ##
===========================================================
+ Coverage                    74.16%   74.93%   +0.77%     
===========================================================
  Files                           81       81              
  Lines                        10080     9976     -104     
===========================================================
  Hits                          7476     7476              
+ Misses                        2604     2500     -104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rocketpy/tools.py Outdated Show resolved Hide resolved
rocketpy/tools.py Outdated Show resolved Hide resolved
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work. Code is much cleaner now, we really appreciate your effort.

I look forward to seeing this feature being released

@phmbressan phmbressan merged commit 3a08f48 into enh/parallel_montecarlo Aug 5, 2024
3 of 8 checks passed
@phmbressan phmbressan deleted the mnt/parallel-refactor branch August 5, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monte Carlo Monte Carlo and related contents
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants