Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Insert apogee state into solution list during flight simulation #638

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented Jul 13, 2024

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Recently reported on discord:
image
image
image

New behavior

The problem was related to Function interpolations. I added the apogee state to the state solution so it created a point at the minimum value of the free stream speed curve (i.e. the apogee). This way we reduced the error when evaluating the stream speed at apogee.

Breaking change

  • No

@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner July 13, 2024 02:51
@Gui-FernandesBR Gui-FernandesBR added Enhancement New feature or request, including adjustments in current codes Flight Flight Class related features labels Jul 13, 2024
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.71%. Comparing base (655f4be) to head (673ac84).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #638   +/-   ##
========================================
  Coverage    75.70%   75.71%           
========================================
  Files           81       81           
  Lines         9813     9815    +2     
========================================
+ Hits          7429     7431    +2     
  Misses        2384     2384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR force-pushed the enh/adds-apogee-state-to-solution-array branch from 32e0d82 to 673ac84 Compare July 14, 2024 19:36
@Gui-FernandesBR Gui-FernandesBR merged commit 27d6bbd into develop Jul 15, 2024
10 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the enh/adds-apogee-state-to-solution-array branch July 15, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request, including adjustments in current codes Flight Flight Class related features
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants