-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: fix pylint errors in the tests
module
#632
Conversation
b533722
to
0d01bf0
Compare
…-Team/RocketPy into mnt/pylint-tests-module
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #632 +/- ##
===========================================
- Coverage 73.92% 73.85% -0.08%
===========================================
Files 70 70
Lines 10032 10035 +3
===========================================
- Hits 7416 7411 -5
- Misses 2616 2624 +8 ☔ View full report in Codecov by Sentry. |
502b991
to
b8ae06a
Compare
…-Team/RocketPy into mnt/pylint-tests-module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good
I really like the grouping of tests into Classes
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
I didn't pylint the
tests
module earlier because @lucasfourier was refactoring the tests. Now I can finally apply pylint for tests!New behavior
Now we are going to see pylint and flake8 warning in the tests module as well!
Breaking change
Additional information