-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add STFT function to Function class #620
ENH: Add STFT function to Function class #620
Conversation
@AdvaitChandorkar07 thank you so much for your contribution! We are going to review your PR as soon as possible. At a first glance, I think it solves the problem as requested by #308 . Good job! |
Thank you for your contribution, @AdvaitChandorkar07, and sorry for the long delay for a review. The results look very similar, although there were some minor differences (check the colors around 25s and at the beginning and end of the signal). One major difference is that the the SciPy FFT magnitude seems to be half of the FFT magnitude computed by RocketPy. Here is the very simple notebook I used to compare SciPy to your implementation. testing_stft.zip Overall, things look very good. Some final comments: |
…/RocketPy into feature/stft-function
Signed-off-by: AdvaitChandorkar07 <[email protected]>
…/RocketPy into feature/stft-function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to figure out what is happening with the tests on the CI.
But tests are passing locally, already a good sign.
Thanks a lot for the contribution, @AdvaitChandorkar07 !! Great work. |
Squash of the following commits: * Add STFT function to Function class * Added feature: Short-Time Fourier Transform function * Added feature: Short-Time Fourier Transform function * "Variable name changes in stft" * "Variable and function name formatting" * "Better Example" * Add STFT function to Function class * Added feature: Short-Time Fourier Transform function * Added feature: Short-Time Fourier Transform function * "Variable name changes in stft" * "Variable and function name formatting" * "Better Example" * Fixed the doctest * "Spectrogram example" * small fixes to STFT function --------- Signed-off-by: AdvaitChandorkar07 <[email protected]> Co-authored-by: Gui-FernandesBR <[email protected]>
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallyCurrent behavior
STFT feature was requested in issue #308 with link to #292 as example
New behavior
Added STFT