-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Reorganize only the test_environment.py tests into Integration/Unit Tests #577
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #577 +/- ##
===========================================
- Coverage 73.73% 71.92% -1.81%
===========================================
Files 70 70
Lines 10334 10334
===========================================
- Hits 7620 7433 -187
- Misses 2714 2901 +187 ☔ View full report in Codecov by Sentry. |
@lucasfourier , why moving just some of the tests of the tests from |
Because the tests that have been moved can be defined as integration tests as opposed to the remaining ones. The fundamental trait is the communication with external dependencies. |
@lucasfourier Can you please re-work on this branch to move all the integration tests at once instead of just some of the tests? |
…er. Some simple documentation rewriting.
… commit and fixes to the testing modules of environment in the unit and integration folders.
433cf4a
to
87e3eae
Compare
@lucasfourier what is the reason for these methods be considered integration and not unit tests? They were moved from unit tests to the integration tests.
The definition of unit and integration are not clear enough. I think it is important that you write down these definition before proceeding with any changes in this PR. This should take a few minutes, but save you from questions like the 3 above. |
…tPy-Team/RocketPy into tst/unit-integration-tests
@Gui-FernandesBR You are 100% right. For some reason i thought pytz made some http request at some point, but it does not. Every test there is an unit test, thank you. |
Tests with connection to API'S/interfaces were moved into the integration folder and therefore are only run with --runslow flag, just for the record. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! @lucasfourier
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
Currently, the folder tests/integration is empty.
New behavior
Integration tests folder is no longer empty and contains integration tests. They are not new, they were simply moved to the right place.
Breaking change
Additional information