-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV: adds coverage configuration file and excluide exceptions from report #570
Merged
Gui-FernandesBR
merged 6 commits into
develop
from
dev/adds-coverage-configuration-file
Mar 24, 2024
Merged
DEV: adds coverage configuration file and excluide exceptions from report #570
Gui-FernandesBR
merged 6 commits into
develop
from
dev/adds-coverage-configuration-file
Mar 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phmbressan
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two main comments before approving this PR:
- I would like to hear your opinion on this matter: I do think that we could remove warnings from the coverage, but in my opinion exceptions shouls be asserted. This is specially relevant in the future when Custom Exceptions are implemented;
- It is high time we implemented a
pyproject.toml
file. This would simplify this PR by removing the need of a new "hidden" file.
coveragerc.
Gui-FernandesBR
force-pushed
the
dev/adds-coverage-configuration-file
branch
from
March 12, 2024 00:37
3a3a311
to
191650f
Compare
….com/RocketPy-Team/RocketPy into dev/adds-coverage-configuration-file
Gui-FernandesBR
force-pushed
the
dev/adds-coverage-configuration-file
branch
from
March 21, 2024 19:07
0c4b26b
to
c5fc055
Compare
….com/RocketPy-Team/RocketPy into dev/adds-coverage-configuration-file
phmbressan
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (not relevant)New behavior
Added some regex rules to a new coverage configuration file to skip the raise exceptions from the tests coverage report.
These lines are not imported to be tested, and therefore not having them covered by tests is totally fine.
We should see a small increase in the coverage statistics.
Breaking change
Additional information