Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Optional argument to show the plot in Function.compare_plots #563

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

Gui-FernandesBR
Copy link
Member

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (not needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Every time you call the the Function.compare_plots method, it will display the plot regardless of your intentions.

New behavior

Added a new argument to the method.
Plus updated the docstring, which was a bit old.

Breaking change

  • No

Additional information

Quite easy to review this one.

@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner February 26, 2024 22:38
@Gui-FernandesBR Gui-FernandesBR changed the base branch from master to develop February 26, 2024 22:39
@Gui-FernandesBR Gui-FernandesBR self-assigned this Feb 26, 2024
@Gui-FernandesBR Gui-FernandesBR added Enhancement New feature or request, including adjustments in current codes Function Everything related to the Function class Docs Docs and examples related labels Feb 26, 2024
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Feb 26, 2024
Copy link
Collaborator

@phmbressan phmbressan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, I see no breaking changes here.

Sometimes it is useful to "manually edit" the fig and ax before showing.

@Gui-FernandesBR Gui-FernandesBR merged commit 35a9439 into develop Feb 27, 2024
@Gui-FernandesBR Gui-FernandesBR deleted the enh/show-compare-plots branch February 27, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Docs and examples related Enhancement New feature or request, including adjustments in current codes Function Everything related to the Function class
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants