Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Motor method 'export_eng' for liquid motors bug fix. (solves #473) #559

Merged
merged 5 commits into from
Feb 26, 2024

Updated changelog.

2f527ff
Select commit
Loading
Failed to load commit list.
Merged

BUG: Motor method 'export_eng' for liquid motors bug fix. (solves #473) #559

Updated changelog.
2f527ff
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 24, 2024 in 1s

72.49% (+0.01%) compared to 79aa3b6

View this Pull Request on Codecov

72.49% (+0.01%) compared to 79aa3b6

Details

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.49%. Comparing base (79aa3b6) to head (2f527ff).
Report is 13 commits behind head on develop.

❗ Current head 2f527ff differs from pull request most recent head dc95974. Consider uploading reports for the commit dc95974 to get more accurate results

Files Patch % Lines
rocketpy/motors/motor.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #559      +/-   ##
===========================================
+ Coverage    72.47%   72.49%   +0.01%     
===========================================
  Files           59       59              
  Lines         9567     9575       +8     
===========================================
+ Hits          6934     6941       +7     
- Misses        2633     2634       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.