-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Splitting conftest.py into several smaller files. #556
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #556 +/- ##
========================================
Coverage 72.47% 72.47%
========================================
Files 59 59
Lines 9567 9567
========================================
Hits 6934 6934
Misses 2633 2633 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, the new structure is just way better than the current one. more robust and scalable.
Please discuss on the comments I've added and let me know if there's something not so clear.
Can you apply black before commiting? Out Makefile has been updated recently if you wanna use the make black
command.
Also, can you confirm the slow tests are passing locally?
Once again, good work here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again for your effort, I really appreciate it, @lucasfourier .
I've added a few more comments on what I think is not ideal yet, could you check it out please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, thank you so much for your contribution, @lucasfourier !!
Tests are now more organized and faster.
You can merge this PR once the tests are all green in github actions. Also, please feel free to close the issue associated with this PR.
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
Currently, conftest.py is unique and top level within the tests directory. However, as observed by @Gui-FernandesBR in #447, the file was getting too big to be properly maintained.
New behavior
Several .py modules were created in order to split the fixtures into modules which results in easier maintenance and proper organization.
Breaking change
Additional information
A bit more info regarding this can be found here:
https://stackoverflow.com/questions/27064004/splitting-a-conftest-py-file-into-several-smaller-conftest-like-parts