Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Update flight trajectory plot axes limits #552

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

Gui-FernandesBR
Copy link
Member

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

The limits for the projections and flight path in the 3D map is a bit odd since some time ago. This is unexpected.

image

New behavior

Improves the plot and restore a better, more intuitive behavior that was present since previous versions.

image

Breaking change

  • No

Additional information

@Gui-FernandesBR Gui-FernandesBR added Bug Something isn't working Outputs Dedicated to visualizations enhancements like prints and plots labels Feb 9, 2024
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Feb 9, 2024
@Gui-FernandesBR Gui-FernandesBR self-assigned this Feb 9, 2024
@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner February 9, 2024 22:01
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fba7fb) 72.48% compared to head (3330c5a) 72.47%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #552      +/-   ##
===========================================
- Coverage    72.48%   72.47%   -0.01%     
===========================================
  Files           59       59              
  Lines         9568     9566       -2     
===========================================
- Hits          6935     6933       -2     
  Misses        2633     2633              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@phmbressan phmbressan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plot looks much better @Gui-FernandesBR , you have some great matplotlib skills.

@Gui-FernandesBR Gui-FernandesBR merged commit e4e67f4 into develop Feb 10, 2024
11 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the bug/3d-trajectory-plot branch February 10, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Outputs Dedicated to visualizations enhancements like prints and plots
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants