Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Elliptical Fins Draw #548

Merged
merged 3 commits into from
Feb 8, 2024
Merged

BUG: Elliptical Fins Draw #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df81dcd
BUG: consider only half of ellipse in shape vector
MateusStano Feb 7, 2024
3972de4
MNT: update changelog
MateusStano Feb 7, 2024
9a1e372
Merge branch 'develop' into bug/elliptical-fins-draw
MateusStano Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ straightforward as possible.
- MNT: Encapsulate quaternion conversions [#537](https://github.com/RocketPy-Team/RocketPy/pull/537)
- MNT: improve the low pass filter and document an example [#538](https://github.com/RocketPy-Team/RocketPy/pull/538)
- ENH: Plotting both power on and off drag curves in a single plot [#547](https://github.com/RocketPy-Team/RocketPy/pull/547)
- BUG: Elliptical Fins Draw [#548](https://github.com/RocketPy-Team/RocketPy/pull/548)

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion rocketpy/rocket/aero_surface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1550,7 +1550,7 @@ def evaluate_geometrical_parameters(self):
return None

def evaluate_shape(self):
angles = np.arange(0, 360, 5)
angles = np.arange(0, 180, 5)
x_array = self.root_chord / 2 + self.root_chord / 2 * np.cos(np.radians(angles))
y_array = self.span * np.sin(np.radians(angles))
self.shape_vec = [x_array, y_array]
Expand Down
Loading