Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Function inputs from CSV file header. #542

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

phmbressan
Copy link
Collaborator

@phmbressan phmbressan commented Jan 27, 2024

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

The Function class did not get the inputs and outputs name from the header of CSV file.

New behavior

If the CSV file has headers, the input and output parameters that are left None will be set from the header information.

Breaking change

  • No

@phmbressan phmbressan self-assigned this Jan 27, 2024
@phmbressan phmbressan requested a review from a team as a code owner January 27, 2024 23:22
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2fee77e) 72.32% compared to head (17eea3c) 72.35%.
Report is 3 commits behind head on develop.

❗ Current head 17eea3c differs from pull request most recent head ad7c573. Consider uploading reports for the commit ad7c573 to get more accurate results

Files Patch % Lines
rocketpy/environment/environment_analysis.py 0.00% 1 Missing ⚠️
rocketpy/simulation/flight.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #542      +/-   ##
===========================================
+ Coverage    72.32%   72.35%   +0.02%     
===========================================
  Files           56       56              
  Lines         9399     9407       +8     
===========================================
+ Hits          6798     6806       +8     
  Misses        2601     2601              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. i confirm it's working as expected.

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. i confirm it's working as expected.

@Gui-FernandesBR Gui-FernandesBR linked an issue Feb 5, 2024 that may be closed by this pull request
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Feb 5, 2024
@Gui-FernandesBR Gui-FernandesBR added the Enhancement New feature or request, including adjustments in current codes label Feb 5, 2024
@phmbressan phmbressan merged commit 3f35ead into develop Feb 7, 2024
1 check passed
@phmbressan phmbressan deleted the enh/function-csv-inputs branch February 7, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request, including adjustments in current codes
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

ENH: automatically gets inputs and outputs from csv file
4 participants