-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Function inputs from CSV file header. #542
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #542 +/- ##
===========================================
+ Coverage 72.32% 72.35% +0.02%
===========================================
Files 56 56
Lines 9399 9407 +8
===========================================
+ Hits 6798 6806 +8
Misses 2601 2601 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. i confirm it's working as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. i confirm it's working as expected.
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
The Function class did not get the inputs and outputs name from the header of CSV file.
New behavior
If the CSV file has headers, the input and output parameters that are left
None
will be set from the header information.Breaking change