Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: 3D trajectory plot not labeling axes #533

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

Gui-FernandesBR
Copy link
Member

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed) (not needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

It's getting into my nerves since 2021 or even more!
image

New behavior

image

Breaking change

  • nooo

Additional information

@Gui-FernandesBR Gui-FernandesBR added Bug Something isn't working Outputs Dedicated to visualizations enhancements like prints and plots labels Jan 14, 2024
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Jan 14, 2024
@Gui-FernandesBR Gui-FernandesBR self-assigned this Jan 14, 2024
@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner January 14, 2024 01:54
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ad62bf4) 71.99% compared to head (7f033d8) 71.99%.
Report is 8 commits behind head on develop.

Files Patch % Lines
rocketpy/utilities.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #533   +/-   ##
========================================
  Coverage    71.99%   71.99%           
========================================
  Files           56       56           
  Lines         9372     9374    +2     
========================================
+ Hits          6747     6749    +2     
  Misses        2625     2625           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rocketpy/plots/flight_plots.py Show resolved Hide resolved
@Gui-FernandesBR Gui-FernandesBR merged commit ee9348d into develop Jan 16, 2024
12 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the bug/3d-trajectory-plot-label branch January 16, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Outputs Dedicated to visualizations enhancements like prints and plots
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants