Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH : improvement csv processing #517
ENH : improvement csv processing #517
Changes from all commits
603182e
2e1d213
9c71dd4
36fb82b
44fd8b7
c76dccb
c729bc6
a985667
3eafa6c
6fc12dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I don't think writing a new file with the processed data is really needed here.
More important, I think, is that we must make it clear to the user that not everything of their file was used (because there were
NaN
). So, could you trigger awarning
that informs if any lines were skipped on source processing.The implementation of this warning is up to you, but I believe that a simple
boolean
that is set toTrue
in thefor
loop above if there were any skipped lines is enough. Then, if thisboolean
isTrue
raise thewarning
.There are other places in
rocketpy
that we raisewarning
s if you want to base the implementation on that. Of course, should you have any doubts don't hesitate in commenting.