-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Shepard Optimized Interpolation - Multiple Inputs Support #515
Conversation
- Minor bug in computation if distance zero solved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #515 +/- ##
===========================================
- Coverage 72.36% 72.16% -0.21%
===========================================
Files 56 56
Lines 9409 9362 -47
===========================================
- Hits 6809 6756 -53
- Misses 2600 2606 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a conflict on the changelog, I solved it and now I'm re-approaving.
Excellent PR, this really demonstrantes how Brillant are some people in our team.
In this case, @phmbressan .
ps.: Thank you numpy
for existing.
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
The optimized method
get_value_opt
forshepard
interpolation had a great speed up by #501. However, this method did not support (even before than the #501) arrays of inputs.New behavior
Inspired by the implementation made in the aforementioned PR, the support for multiple inputs was added in the optimized way, benefiting from the great speed up implemented. Since this also satisfies the requisites for the common
get_value
method while being faster, it was also updated.Breaking change