Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Shepard Optimized Interpolation - Multiple Inputs Support #515

Merged
merged 11 commits into from
Jan 25, 2024

Conversation

phmbressan
Copy link
Collaborator

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

The optimized method get_value_opt for shepard interpolation had a great speed up by #501. However, this method did not support (even before than the #501) arrays of inputs.

New behavior

Inspired by the implementation made in the aforementioned PR, the support for multiple inputs was added in the optimized way, benefiting from the great speed up implemented. Since this also satisfies the requisites for the common get_value method while being faster, it was also updated.

Breaking change

  • No

@phmbressan phmbressan added the Enhancement New feature or request, including adjustments in current codes label Dec 19, 2023
@phmbressan phmbressan added this to the Release v1.X.0 milestone Dec 19, 2023
@phmbressan phmbressan self-assigned this Dec 19, 2023
@phmbressan phmbressan requested a review from a team as a code owner December 19, 2023 00:34
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2086996) 72.36% compared to head (1de49c9) 72.16%.
Report is 6 commits behind head on develop.

❗ Current head 1de49c9 differs from pull request most recent head 48e4f5d. Consider uploading reports for the commit 48e4f5d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #515      +/-   ##
===========================================
- Coverage    72.36%   72.16%   -0.21%     
===========================================
  Files           56       56              
  Lines         9409     9362      -47     
===========================================
- Hits          6809     6756      -53     
- Misses        2600     2606       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job here. Thanks for the contribution.

image

tests/unit/test_function.py Outdated Show resolved Hide resolved
tests/unit/test_function.py Outdated Show resolved Hide resolved
rocketpy/mathutils/function.py Outdated Show resolved Hide resolved
tests/unit/test_function.py Outdated Show resolved Hide resolved
tests/test_function.py Outdated Show resolved Hide resolved
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a conflict on the changelog, I solved it and now I'm re-approaving.

Excellent PR, this really demonstrantes how Brillant are some people in our team.
In this case, @phmbressan .

ps.: Thank you numpy for existing.

@phmbressan phmbressan merged commit 5d09d4a into develop Jan 25, 2024
7 checks passed
@phmbressan phmbressan deleted the enh/shepard-multiple-opt branch January 25, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request, including adjustments in current codes
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants