Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: v1.1.4 #503

Merged
merged 13 commits into from
Dec 9, 2023
Merged

REL: v1.1.4 #503

merged 13 commits into from
Dec 9, 2023

Conversation

MateusStano
Copy link
Member

[v1.1.4] - 2023-12-07

Fixed

  • DOC: Change from % to ! in the first cell to run properly in Colab. #496
  • FIX: changes Generic Motor exhaust velocity to cached property #497

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d6f244) 70.95% compared to head (0c49c0b) 70.92%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
- Coverage   70.95%   70.92%   -0.04%     
==========================================
  Files          55       55              
  Lines        9262     9262              
==========================================
- Hits         6572     6569       -3     
- Misses       2690     2693       +3     
Flag Coverage Δ
unittests 70.92% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR
Copy link
Member

The CHANGELOG seems messy.
I'm going to take a look at this rn


### Fixed

- DOC: Change from % to ! in the first cell to run properly in Colab. [#496](https://github.com/RocketPy-Team/RocketPy/pull/496)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not necessary for changelog. I'm going to update the changelog description to avoid future mistakes.

PLease don't accept suggestion

Suggested change
- DOC: Change from % to ! in the first cell to run properly in Colab. [#496](https://github.com/RocketPy-Team/RocketPy/pull/496)

Gui-FernandesBR
Gui-FernandesBR previously approved these changes Dec 7, 2023
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Looks Good To Me

phmbressan
phmbressan previously approved these changes Dec 7, 2023
Copy link
Member

@giovaniceotto giovaniceotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not comfortable with changes made to the changelog file description. A release PR is not the place to make them, so I request they are removed for now. Sorry for being so pedantic here, but I believe this is important. In Brazil, such changes are referred as "jabutis" and they can be quite problematic in the long run since the discussion of these changes are often overlooked and shadowed by more important things.

Although not important here, in my opinion, the changelog file is not a release notes meant to please only end users. We already have the official release notes for that. The changelog is meant for all involved in the project to keep track of what is changing.

*Just to be clear, I am not against changes to the changelog, I am against changes to the scope of the changelog file, as a tag along in this PR.

@Gui-FernandesBR Gui-FernandesBR dismissed stale reviews from phmbressan and themself via 0c49c0b December 7, 2023 04:07
@Gui-FernandesBR
Copy link
Member

I am not comfortable with changes made to the changelog file description. A release PR is not the place to make them, so I request they are removed for now. Sorry for being so pedantic here, but I believe this is important. In Brazil, such changes are referred as "jabutis" and they can be quite problematic in the long run since the discussion of these changes are often overlooked and shadowed by more important things.

Although not important here, in my opinion, the changelog file is not a release notes meant to please only end users. We already have the official release notes for that. The changelog is meant for all involved in the project to keep track of what is changing.

*Just to be clear, I am not against changes to the changelog, I am against changes to the scope of the changelog file, as a tag along in this PR.

Thank you for submitting a review, @giovaniceotto ,

I reverted the previous commit as suggested.

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MateusStano

@MateusStano MateusStano merged commit fa3d9a7 into master Dec 9, 2023
12 of 13 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the rel/v1.1.4 branch December 15, 2023 07:18
@Gui-FernandesBR Gui-FernandesBR added the Releases Related with new releases label Jan 21, 2024
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Releases Related with new releases
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants