-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REL: v1.1.4 #503
REL: v1.1.4 #503
Conversation
This reverts commit ecf536d.
…icMotor to avoid lambdas
…velocity-stalls-flight FIX: changes Generic Motor exhaust velocity to cached property
…lab-notebook-error DOC: Change from % to ! in the first cell to run properly in Colab.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #503 +/- ##
==========================================
- Coverage 70.95% 70.92% -0.04%
==========================================
Files 55 55
Lines 9262 9262
==========================================
- Hits 6572 6569 -3
- Misses 2690 2693 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The CHANGELOG seems messy. |
|
||
### Fixed | ||
|
||
- DOC: Change from % to ! in the first cell to run properly in Colab. [#496](https://github.com/RocketPy-Team/RocketPy/pull/496) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is not necessary for changelog. I'm going to update the changelog description to avoid future mistakes.
PLease don't accept suggestion
- DOC: Change from % to ! in the first cell to run properly in Colab. [#496](https://github.com/RocketPy-Team/RocketPy/pull/496) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Looks Good To Me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not comfortable with changes made to the changelog file description. A release PR is not the place to make them, so I request they are removed for now. Sorry for being so pedantic here, but I believe this is important. In Brazil, such changes are referred as "jabutis" and they can be quite problematic in the long run since the discussion of these changes are often overlooked and shadowed by more important things.
Although not important here, in my opinion, the changelog file is not a release notes meant to please only end users. We already have the official release notes for that. The changelog is meant for all involved in the project to keep track of what is changing.
*Just to be clear, I am not against changes to the changelog, I am against changes to the scope of the changelog file, as a tag along in this PR.
This reverts commit 7d553c2.
0c49c0b
Thank you for submitting a review, @giovaniceotto , I reverted the previous commit as suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MateusStano
[v1.1.4] - 2023-12-07
Fixed