Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc/adding tst to docs #491

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Doc/adding tst to docs #491

merged 1 commit into from
Nov 28, 2023

Conversation

lucasfourier
Copy link
Contributor

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Currently, the documentation style guide regarding branch naming conventions does not include 'tst' as a possible branch name nor provides an example.

New behavior

Adding 'tst' to branch naming convention.

Breaking change

  • Yes
  • No

Additional information

Current doc page.

image

Adding tests (tst) to the branch naming conventions in the git style page.
@lucasfourier lucasfourier requested review from MateusStano and removed request for MateusStano November 28, 2023 12:41
@lucasfourier lucasfourier added the Docs Docs and examples related label Nov 28, 2023
@giovaniceotto giovaniceotto changed the base branch from master to develop November 28, 2023 14:20
@lucasfourier lucasfourier merged commit 214e4c2 into develop Nov 28, 2023
5 checks passed
@lucasfourier lucasfourier deleted the doc/adding-tst-to-docs branch November 28, 2023 16:23
@Gui-FernandesBR
Copy link
Member

I believe it's about time to redefine the commit messages and PR style guide.

I hope I've commited enough "MNT" instead of "MAINT" to convince you that is better.
Also, sometimes a "FIX" or "HOTFIX" appears here without being documented...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Docs and examples related
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants