-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Parachute trigger doesn't work if "Apogee" is used instead of "apogee" #489
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #489 +/- ##
===========================================
- Coverage 70.91% 70.90% -0.01%
===========================================
Files 55 55
Lines 9261 9263 +2
===========================================
+ Hits 6567 6568 +1
- Misses 2694 2695 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix.
Improvement suggestion: line 129 of rocketpy/rocket/parachute.py
- The string "apogee," which triggers the parachute at apogee, i.e., when the rocket reaches its highest point and starts descending.
I believe we should change from "apogee,"
to "apogee",
.
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
New behavior
Breaking change
Additional information
Reported by jackson.dendy on discord tonight, from the univ of Tenesse.