Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Prevent out of bounds Tanks from Instantiation #484

Merged
merged 5 commits into from
Nov 24, 2023

Merge branch 'hotfix/v1.1.1' into bug/tanks-overfill

dab946d
Select commit
Loading
Failed to load commit list.
Merged

ENH: Prevent out of bounds Tanks from Instantiation #484

Merge branch 'hotfix/v1.1.1' into bug/tanks-overfill
dab946d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 24, 2023 in 0s

70.84% (+0.01%) compared to 3434ae9

View this Pull Request on Codecov

70.84% (+0.01%) compared to 3434ae9

Details

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (3434ae9) 70.83% compared to head (dab946d) 70.84%.

Files Patch % Lines
rocketpy/motors/tank.py 69.69% 10 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           hotfix/v1.1.1     #484      +/-   ##
=================================================
+ Coverage          70.83%   70.84%   +0.01%     
=================================================
  Files                 55       55              
  Lines               9240     9258      +18     
=================================================
+ Hits                6545     6559      +14     
- Misses              2695     2699       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.