-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REL: v1.1.1 #483
REL: v1.1.1 #483
Conversation
DOC: Add RocketPy change log file
HOTFIX: Negative Static Margin
HOTFIX: 2D .CSV Function and missing set_get_value_opt call
HOTFIX: Tanks Overfill not Being Detected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MateusStano !!
2 changes that we still need to do before merging:
- Update the CHANGELOG file.
- Re-run the SEBLM notebook to update the static margin plot. See:
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
==========================================
+ Coverage 70.80% 70.89% +0.08%
==========================================
Files 55 55
Lines 9234 9258 +24
==========================================
+ Hits 6538 6563 +25
+ Misses 2696 2695 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We should have more tests for the tanks, not all the lines are being covered right now, as reported by the codecov |
This one solves #482 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great one!
ENH: Prevent out of bounds Tanks from Instantiation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fixes. I just noticed a small assertion mistake and will commit a fix.
Fixed
#479:
#478:
#476: