Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: v1.1.1 #483

Merged
merged 31 commits into from
Nov 24, 2023
Merged

REL: v1.1.1 #483

merged 31 commits into from
Nov 24, 2023

Conversation

MateusStano
Copy link
Member

Fixed

#479:

  • Opposite static margin bug, which affected all rockets defined using a nose_to_tail coordinate system, causing positive static margins to become negative and negative ones to become positive. Note: this bug did not lead to any issues in terms of the trajectory simulation itself.

#478:

  • Fixed Bug in 2D .csv-Based Functions for Proper Interpolation Handling and Added Relevant Test Coverage

#476:

  • Corrected Function.compose extrapolation.
  • Added overfill validation in MassBasedTank.fluid_volume.
  • Introduced assertion in test_mass_based_tank to prevent future errors in fluid_volume.

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MateusStano !!

2 changes that we still need to do before merging:

  • Update the CHANGELOG file.
  • Re-run the SEBLM notebook to update the static margin plot. See:

image

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (afcbf02) 70.80% compared to head (6015dcc) 70.89%.
Report is 1 commits behind head on master.

Files Patch % Lines
rocketpy/motors/tank.py 71.05% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
+ Coverage   70.80%   70.89%   +0.08%     
==========================================
  Files          55       55              
  Lines        9234     9258      +24     
==========================================
+ Hits         6538     6563      +25     
+ Misses       2696     2695       -1     
Flag Coverage Δ
unittests 70.89% <77.08%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR
Copy link
Member

We should have more tests for the tanks, not all the lines are being covered right now, as reported by the codecov

@Gui-FernandesBR
Copy link
Member

This one solves #482

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one!

Copy link
Collaborator

@phmbressan phmbressan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fixes. I just noticed a small assertion mistake and will commit a fix.

tests/test_tank.py Outdated Show resolved Hide resolved
@MateusStano MateusStano merged commit 5ff3476 into master Nov 24, 2023
13 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the hotfix/v1.1.1 branch November 25, 2023 19:20
@Gui-FernandesBR Gui-FernandesBR changed the title HOTFIX: v1.1.1 REL: v1.1.1 Jan 21, 2024
@Gui-FernandesBR Gui-FernandesBR added the Releases Related with new releases label Jan 21, 2024
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Releases Related with new releases
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants