REL: v1.1.0 #469
Merged
REL: v1.1.0 #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-Team/RocketPy into enh/new-stability-margin
Gui-FernandesBR
requested review from
Gui-FernandesBR,
phmbressan,
lucasfourier and
FranzYuri
Made some changes according to the comments made in the PR.
TST: new set of tests
- Fix colormap get method avoiding deprecation from matplotlib - Fix interpolation/extrapolation warnings in Function class - avoid using Function.plot2D old method - delete the too general exception from the funcify.
LiquidMotor class - There's a problem when someone passes a mass flow curve with different a discretization than the thrust curve. (which is the case for the SEBLM motor) - I'm raising a new error to allow the user to solve the issue before continuing.
- Fix variable naming "xinitial", I also checked this is nto used in other classes - update interpolation and extrapolation methods usage - remove useless raises or warnings.
|
For strange reason (scipy), the Also, a rebase with develop is necessary after reviewing and merging #470 |
Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
- Fix exhaust velocity calculation for non-zero mass flow rates - remove useless if statement - change if to elif statement. - all the tested passing without warnings.
BUG: Fix find_input() Function to Return a Single Value
MNT: solve warnings
Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
Gui-FernandesBR
approved these changes
Nov 19, 2023
There was a problem hiding this comment.
Amazing release, the 225 commits brought valuable new features to rocketpy, while improving the current ones.
Let's try to increase the frequency of releases so we don't get so long changelogs. Small versions are easier to track, review and allow for a better experience from the user side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging for release of v1.1.0