BUG: fix extrapolation of multivariable functions. #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems duplicated with #451 . @phmbressan please see it first before the revision |
You are absolutely correct. I will merge the tests from this PR to #451. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCurrent behavior
The construction of a multivariable
Functionfrom a dataset (e.g.[(0,0,0), (0,1,1), ...]) triggered an extrapolation error since it was being keptNonewhen callingget_value_opt.New behavior
The error was fixed by setting the extrapolation type on
set_sourcesimilarly to what occurs when the dataset is one dimensional. Tests for the changes have been added.Breaking change