Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: fix env plots legends #440

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Conversation

Gui-FernandesBR
Copy link
Member

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest --runslow) have passed locally

Current behavior

the wind_u and wind_v labels are not being used for plotting the wind profile in the Environemnt.all_info() method. This makes it impossible to be read.

New behavior

Simply adding the legend where it is needed.

Breaking change

  • No

Additional information

Simple fix based on a recent feedback we got at EuRoC this year.

@Gui-FernandesBR Gui-FernandesBR added Outputs Dedicated to visualizations enhancements like prints and plots Environment Enviroment Class related features labels Oct 14, 2023
@Gui-FernandesBR Gui-FernandesBR self-assigned this Oct 14, 2023
@Gui-FernandesBR Gui-FernandesBR merged commit eb44ff8 into develop Oct 14, 2023
10 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the mnt/fix-env-plots-legend branch October 14, 2023 23:23
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Environment Enviroment Class related features Outputs Dedicated to visualizations enhancements like prints and plots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants