MNT: Fix env plots max heights

[Gui-FernandesBR]

Pull request type

• Code changes (bugfix, features)
• Code maintenance (refactoring, formatting, tests)
• ReadMe, Docs and GitHub updates
• Other (please describe):

Checklist

• Tests for the changes have been added (if needed)
• Docs have been reviewed and added / updated
• Lint (black rocketpy/ tests/) has passed locally
• All tests (pytest --runslow) have passed locally

Current behavior

• Extremally annoying to see the gravity plot on the oposite orientation relative to the other plots in Environment.all_info()
• Thanks to the following code line, the refreshment of the max_expected_height variable wasn't being updated after the self.plots initialization.

  RocketPy/rocketpy/plots/environment_plots.py

  Line 31 in dfee9fe

  self.grid = np.linspace(environment.elevation, environment.max_expected_height)

New behavior

• There is a simple setter for the max_expected_height, which will also update the grid value in the plots.. I considered different approaches, and implemented the best that I found.
• I removed some code repetitions from the Environment.init() method. The class initialization should be faster now.

Breaking change

• Yes
• No

Additional information

• In the future, I would love to see the same plots with scatters over the lines, just to check the data retrieved from the APIs. Not a job for this PR tho.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[MateusStano]

Wow! Finally someone fixed this!

I would just suggest to add some env.max_expected_height parameters to notebooks/docs pages

[MateusStano]

Also, just thought about this, but maybe max_expected_height should be an optional argument in Environment Init

[Gui-FernandesBR]

Also, just thought about this, but maybe max_expected_height should be an optional argument in Environment Init

Solved! Although it is currently kinda useless, it has the potential for allowing us to speed up the Environment initialization

[Gui-FernandesBR]

Wow! Finally someone fixed this!

I would just suggest to add some env.max_expected_height parameters to notebooks/docs pages

I updated the geting started notebook, I can update the other in another moment.