-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Refactor README #418
DOC: Refactor README #418
Conversation
Good improvement, @giovaniceotto ! The images are not rendering to me when I build the docs here. Could you confirm if these are working for you? Dark mode also have the same behavior |
link to the readthedocs: https://docs.rocketpy.org/en/docs-refactor-readme/ The rocketpy logo is still not working. |
Good catch! I'll attempt a simple fix by the end of the day, trying to link the images using raw blobs.
However, in the long run, we need to unlink our Docs homepage from our ReadMe. I would leave that for a separate PR so that we can merge this one soon.
|
OK, I agree if you suggest to remove the README.md from the docs. Maybe we could copy the same style as in Numpy and Pandas' docs: But for this PR what I think you could do is this: ![Logo Dark](https://image-link.png#gh-dark-mode-only)
![Logo Light](https://image-link.png#gh-light-mode-only) The Opening an issue for the first task is recommended |
Unfortunately, that is already deprecated. GitHub will not support that anymore soon, as outlined in the link available in the PR description. That being said, I do not believe the HTML tags are the problem. The problem is only the link. |
@Gui-FernandesBR, this is ready for final review. Here are a couple of notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A masterpiece, as expected from a master.
Thank you so much for fixing the errors, @giovaniceotto !!
Seems to be an issue with dark and light mode theme. From what I understand right now, GitHub and RTD handle an image for each them differently. We fixed it on GitHub, and now it's broken on RTD. RTD seems to be using the image considering the browser color theme. However, it also has it's own theme toggle, which does not update the image. That confuses thinks. I'll attempt to investigate further. |
Maybe the conf.py of sphinx has an option to toggle which theme is the deafult |
Pull request type
Checklist
Current behavior
New behavior
/docs/static/institutional
Breaking change