Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: update motor docstrings regarding coordinate systems #406

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

phmbressan
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • ReadMe, Docs and GitHub maintenance:

    • Spelling has been verified
    • Code docs are working correctly

What is the current behavior?

The documentation regarding Tanks and Motor additions were outdated and did not reflect the implemented code. Generic motors were also lacking proper constructor description.

What is the new behavior?

The documentation was updated.

Does this introduce a breaking change?

  • Yes
  • No

@phmbressan phmbressan added the Docs Docs and examples related label Sep 7, 2023
@phmbressan phmbressan added this to the Release v1.0.0 milestone Sep 7, 2023
@phmbressan phmbressan self-assigned this Sep 7, 2023
Copy link
Member

@MateusStano MateusStano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! Merging now

@MateusStano MateusStano merged commit 7b3a7bc into doc/docs-overview Sep 11, 2023
@MateusStano MateusStano deleted the doc/update-motor-docstrings branch September 11, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Docs and examples related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants