-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: update github workflows files #405
MAINT: update github workflows files #405
Conversation
- no longer assigns the issue to its author (only for PRs) - deleted the useless auto-assign-projects file - runs the pytest without the [all] option
Is this PR really working as intended? You mentioned in the description that it is by itself a test of the new files, but I have not been assigned as a reviewer. Furthermore, shouldn't the destination branch of this PR be |
You know, since there's no way to test it, sometimes you have to trust that the workflows are gonna work 😅😅😅
Anyway, many thanks for reviewing it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the changes made. Approved.
Merging it into fix/env-analysis-dependency-imports |
cfdd041
into
fix/env-analysis-dependency-imports
Actually, I think the workflow you start working correctly only when it gets to the master branch. |
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
ReadMe, Docs and GitHub maintenance:
What is the current behavior?
The github workflows are not perfect.
What is the new behavior?
They continue not being perfect, but at least now they are updated. Also:
Does this introduce a breaking change?
Other information