-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flight.allInfo() has been remodeled! #36
Merged
giovaniceotto
merged 20 commits into
RocketPy-Team:master
from
Gui-FernandesBR:enhancement/allinfo_functions
Jul 31, 2020
Merged
Flight.allInfo() has been remodeled! #36
giovaniceotto
merged 20 commits into
RocketPy-Team:master
from
Gui-FernandesBR:enhancement/allinfo_functions
Jul 31, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Flight.allInfo () has been separated into 12 other functions, so that we can plot specific graphics more freely. However, Flight.allInfo () still exists and still works as usual. - Some changes in what is printed by the functions, numerical and graphic information. Better axis limits for various graphs. Added some prints for the Burn Out Time. - Added a function capable of estimating the critical speed of fin flutter. - Added a new attribute: thrustToWeight, it is defined as the ratio between the thrust force of the motor and the weight of the rocket - Added a function that allows you to export pressure signals to an external file, I hope it will be useful for the Eletronics Subsystem team. - Important: There are now two more parameters to be used as the rail length! The "effective1RL" represents the distance between the upper rail button and the top of the launch rail.
- Some changes in the addFins() function to allow Fin analysis in the flight class - Inertia details now prints data using .format options
giovaniceotto
requested changes
Jul 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a couple of suggestions. Let me know if you have any doubts or would like to further discuss them.
- Suggestion accepted Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
accepted suggestion Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
accepted suggestion Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
accepted suggestion Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
- thrustToWeight Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
Numerical integration prints Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
Update rocketpy/Flight.py Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
Update rocketpy/Flight.py Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
giovaniceotto
approved these changes
Jul 31, 2020
Gui-FernandesBR
added
the
Outputs
Dedicated to visualizations enhancements like prints and plots
label
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Rocket class:
Several changes in Flight class: