Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Monte Carlo Analysis Enhancements #269

Open
1 of 17 tasks
giovaniceotto opened this issue Nov 5, 2022 · 1 comment · May be fixed by #619
Open
1 of 17 tasks

ENH: Monte Carlo Analysis Enhancements #269

giovaniceotto opened this issue Nov 5, 2022 · 1 comment · May be fixed by #619
Assignees
Labels
Enhancement New feature or request, including adjustments in current codes Function Everything related to the Function class Monte Carlo Monte Carlo and related contents

Comments

@giovaniceotto
Copy link
Member

giovaniceotto commented Nov 5, 2022

Everyone loves the fact that RocketPy can be quite easily wrapped to run Monte Carlo simulations to carry on dispersion analysis.

However, this experience quickly becomes hard as the analysis complexity increases. Usually, lack of a good stopping criteria combined with long simulation times are the main issues.

Therefore, the following requirements are specified to improve general Monte Carlo simulations with RocketPy.

Requirements

New features

  • 1. Support for multithreading in order to speed up calculations.
  • 2. Support for confidence interval estimation using bootstrapping.
  • 3. Have a convergence criteria based on maximum confidence interval rather then number of simulations.
  • 4. Speed up of each simulation to decrease total Monte Carlo analysis time. (PR ENH: Flight simulation speed up #581 )
  • 5. Implement the MRS method (issue ENH: Implement MRS method on RocketPy! #162)
  • 6. Allow users to input custom distribution functions for sampling [See Ref.1]
  • 7. implement HybridMotor and LiquidMotor stochastic models (not sure how to do it yet)
  • 8. Save the outputs in different file formats and file structure: ENH: Save dispersion outputs in different file formats #242
  • 9. Improve the ellipses image generation: automatically downloads satellite images from the internet

Corrections:

  • 1. Create evolution plots to analyze simulation convergence
  • 2. Don't use built-in functions in new methods (words like "object", "getattr" and "type" are reserved)
  • 3. Make lat and lon optional arguments in the export_ellipses_to_kml function
  • 4. Review fixed/variable attributes: prevent timezone, number_of_grains, nose_kind to be varied
  • 5. Refactor the StochasticFlight.create_object to avoid unnecessary calls.
  • 6. Stop using assert in production code. Use exceptions instead.
  • 7. Refactor and simplify the StochasticModel.__init__() method
  • 8. Move the _validate_airfoil method to a child class

Proposed Milestone

v1.X (This means we will avoid breaking changes as much as possible)

Additional comments

Ref.1 -> There are certain quantities, e.g. wind speed, that the user might have a more accurate distribution (maybe built empirically) that does not fit Numpy's provided distributions. The user could provide a "sampler," i.e. a function that takes an integer sample_size as input and outputs that amount of samples according to his distribution.)

@giovaniceotto giovaniceotto added Enhancement New feature or request, including adjustments in current codes Function Everything related to the Function class labels Nov 5, 2022
@giovaniceotto giovaniceotto added this to the Release v1.1.0 milestone Nov 5, 2022
@Gui-FernandesBR Gui-FernandesBR added the Monte Carlo Monte Carlo and related contents label Nov 15, 2022
@MateusStano MateusStano moved this from Long-Term to Mid-Term in LibDev Roadmap Nov 5, 2023
@MateusStano MateusStano moved this from Mid-Term to Next Version in LibDev Roadmap Nov 22, 2023
@MateusStano MateusStano moved this from Next Version to Mid-Term in LibDev Roadmap Nov 29, 2023
@Gui-FernandesBR Gui-FernandesBR moved this from Mid-Term to Backlog in LibDev Roadmap Jul 10, 2024
@Gui-FernandesBR Gui-FernandesBR changed the title Monte Carlo Analysis Enhancements ENH: Monte Carlo Analysis Enhancements Nov 2, 2024
@Gui-FernandesBR Gui-FernandesBR linked a pull request Dec 8, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request, including adjustments in current codes Function Everything related to the Function class Monte Carlo Monte Carlo and related contents
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants