Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Callback function for collecting additional data from Monte Carlo sims #699

Closed
emtee14 opened this issue Oct 1, 2024 · 3 comments · Fixed by #702
Closed

ENH: Callback function for collecting additional data from Monte Carlo sims #699

emtee14 opened this issue Oct 1, 2024 · 3 comments · Fixed by #702
Assignees
Labels
Enhancement New feature or request, including adjustments in current codes Help wanted Extra attention is needed Monte Carlo Monte Carlo and related contents

Comments

@emtee14
Copy link

emtee14 commented Oct 1, 2024

Is your feature request related to a problem? Please describe.

When running Monte Carlo sims currently you are limited to the predefined variables when exporting the results. For certain applications, I'd like to be able to get other data points that aren't already in the default list or generate my own variables from the Flight class after the sim has run and add them to the exported dict. My primary use for this would be to export environmental data as at the moment when aggregating multiple sims together with multiple different dates/times or weather forecasts the only way to differentiate is by embedding the data in the file name which becomes quite arduous when you have a lot of additional data you want to add. It can also be useful to export sensor data since it can then be used for sensor mocking.

Describe the solution you'd like

My idea to fix this would be a function you pass to the MonteCarlo class which takes a Flight as an argument and returns a dict which can then be appended to the output dict of the simulation. This would allow other data points to be exported like environmental data and sensor data from the rocket.

Additional context

@emtee14
Copy link
Author

emtee14 commented Oct 1, 2024

Also to add myself or someone from LURA is happy to implement this

@Gui-FernandesBR Gui-FernandesBR added Enhancement New feature or request, including adjustments in current codes Monte Carlo Monte Carlo and related contents labels Oct 1, 2024
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Oct 1, 2024
@Gui-FernandesBR Gui-FernandesBR changed the title Callback function for collecting additional data from Monte Carlo sims ENH: Callback function for collecting additional data from Monte Carlo sims Oct 11, 2024
@Gui-FernandesBR Gui-FernandesBR added the Help wanted Extra attention is needed label Oct 11, 2024
@Gui-FernandesBR
Copy link
Member

related: #269

@Gui-FernandesBR
Copy link
Member

This is coming as a new feature in the next release!

@github-project-automation github-project-automation bot moved this from Backlog to Closed in LibDev Roadmap Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request, including adjustments in current codes Help wanted Extra attention is needed Monte Carlo Monte Carlo and related contents
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

3 participants