Integrate liquid and hybrid motors #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielBarberini
requested review from
giovaniceotto,
luimot,
Gui-FernandesBR and
MateusStano
luimot
reviewed
Nov 5, 2023
luimot
reviewed
Nov 18, 2023
| @@ -15,7 +15,6 @@ def get_os_secret(key): | |||
| def get_secret(self, key): | |||
| dotenv_secret = self.secrets.get(key) | |||
| if not dotenv_secret: | |||
| print("cheguei") | |||
luimot
previously approved these changes
Nov 18, 2023
README.md
Outdated
implements motor tanks implements guard on motor to cover hybrid and liquid inputs improves motors model readability improves motors model readability improves models visibility implements MotorTankGeometry implements API logger implements hashing for rocket model and udpates api docs adapts flight controller to hybrid adapt updates to hybrid updates flight controller to support hybrid updates start saving rocket option and motor kind adapts flight to save rocket options and motor kind state adds obs in README about compatibility with python 3.11.5 removes dead code and reduces import line size
GabrielBarberini
force-pushed
the
serialization
branch
from
6b168be to
6036e56
Compare
luimot
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Liquid and hybrid motors integration
📝 Briefing 🎯
Currently api.rocketpy.org supports only solid motors, this commit is a design upgrade that enables solid, liquid, and hybrid motors to be used through the API. Additional enhancements in the design were also applied to serve as a scaffold for the next improvements such as allowing custom engine file input, selectable off-shelf engine files, etc.
🕵️ Review focus 🔎
I would like to kindly ask your help to check for performance improvements and flag any anti-patterns you find since In order to solve some of the integration issues I had to make some not-so-elegant work-around.
🔬 Tests 🧪
The Postman collection is yet to be updated with additional functional tests to cover this change. I've also tested every route for hybrid, solid, and liquid with the preset values and fixed all critical issues/bugs along the way. Still, I would like you to give it a try yourself to help me test a few edge cases, probably there are some covert bugs lying around.
Additional info