Skip to content

Commit

Permalink
addresses PR review
Browse files Browse the repository at this point in the history
  • Loading branch information
GabrielBarberini committed Oct 13, 2024
1 parent 0c1a979 commit eb3d79a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
3 changes: 1 addition & 2 deletions lib/models/environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ class AtmosphericModelTypes(str, Enum):
STANDARD_ATMOSPHERE: str = "STANDARD_ATMOSPHERE"
CUSTOM_ATMOSPHERE: str = "CUSTOM_ATMOSPHERE"
WYOMING_SOUNDING: str = "WYOMING_SOUNDING"
NOAARUCSOUNDING: str = "NOAARUCSOUNDING"
FORECAST: str = "FORECAST"
REANALYSIS: str = "REANALYSIS"
ENSEMBLE: str = "ENSEMBLE"
Expand All @@ -17,7 +16,7 @@ class AtmosphericModelTypes(str, Enum):
class Env(BaseModel):
latitude: float
longitude: float
elevation: Optional[int] = None
elevation: Optional[int] = 0

# Optional parameters
atmospheric_model_type: Optional[AtmosphericModelTypes] = None
Expand Down
3 changes: 3 additions & 0 deletions lib/models/motor.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ class InterpolationMethods(str, Enum):
LINEAR: str = "LINEAR"
SPLINE: str = "SPLINE"
AKIMA: str = "AKIMA"
POLYNOMIAL: str = "POLYNOMIAL"
SHEPARD: str = "SHEPARD"
RBF: str = "RBF"


class MotorTank(BaseModel):
Expand Down
5 changes: 4 additions & 1 deletion lib/models/rocket.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ class Rocket(BaseModel):
mass: float
motor_position: float
center_of_mass_without_motor: int
inertia: Tuple[float, float, float]
inertia: Union[
Tuple[float, float, float],
Tuple[float, float, float, float, float, float],
]
power_off_drag: List[Tuple[float, float]]
power_on_drag: List[Tuple[float, float]]

Expand Down
2 changes: 0 additions & 2 deletions lib/views/flight.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,6 @@ class FlightSummary(RocketSummary, EnvSummary):
z: Optional[Any]
z_impact: Optional[Any]
flight_phases: Optional[Any]
FlightPhases: Optional[Any]
TimeNodes: Optional[Any]

class Config:
json_encoders = {Any: to_python_primitive}
Expand Down

0 comments on commit eb3d79a

Please sign in to comment.