Added nodeSelector to deployments #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can confirm we need |
|
@atropos112 I can't see the |
|
Thanks @ChrisJBurns , I added the nodeSelector bit to values. Was testing by changing value.yaml file and once I felt everything worked i "git restored" the values.yaml forgetting there was a change there, thanks ! Added nodeSelector to values.yaml now. |
|
You missed the hook-verify-mongodb-version.yaml file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am in need of node selector, because my cluster has nodes with amd64 as well as arm64 architectures and rocketchat doesn't have arm64 images so was crashlooping.
I can't see a single reason not to add this to main line and let others use this when they please, hence the PR. The issue made here: #99
Note the mongodb also has to have nodeSelector set but its already present in that helm chat.