fix: multi select

[SySagar]

fix(multi select): Collapse and scroll on open fixed

• I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
• I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
• Lint and unit tests pass locally with my changes
• I have labeled the PR correctly with the related package
• I have run visual regression tests (if applicable)
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

• added a state variable to control visibility
• stopped the scrolling of select on open state

Issue(s)

Closes #1281
Closes #1284

[changeset-bot]

⚠️ No Changeset found

Latest commit: ab56c61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[Spiral-Memory]

@SySagar , could you please explain what you mean by the collapse issue you mentioned? I believe there is already a pull request raised at #1265 for that particular issue. Please check it out and see if it addresses the same problem you have resolved here.

[SySagar]

Yes I check the pr earlier but it resolves only the collapse not the scrolling part
In my pr both my the problems addressed are resolved

[Spiral-Memory]

@SySagar Yeah, that's good. Now, you can focus on the scrolling issue only, as the other problem has already been addressed. Having multiple PRs solving the same issue will result in confusion. You can remove that commit and force push.

[SySagar]

Wouldn’t it be good if this pr closes both or I can update the other pr don’t know if that is possible

[Spiral-Memory]

@SySagar , but that has already been addressed, right? There has been effort put into solving the issue. Having multiple PRs solving the same issue may waste others' efforts.

[SySagar]

No worried I will force push this will that be ok?or should I update that pr of other person

[Spiral-Memory]

No worried I will force push this will that be ok?

Yeah sure. Thank you for your understanding, You can also update your issue solving the scroll issue.

[Spiral-Memory]

No worried I will force push this will that be ok?or should I update that pr of other person

You won't be able to edit PR of other person. So you can go with removing the second commit and force push.

[dougfabris]

Hi there, thanks for the contribution! 🚀 💯

We're planning an entire replacement of all the components related to AutoComplete and all the Select components since we're focusing a lot on accessibility. Trying to maintain it became a nightmare, and because of that we're not going to accept any contributions related to these components at this time.

---

Questions? Help needed? Feature Requests?

• Join our Open Server in the #support channel and feel free to raise a question
• Join our Community Forum and search/create a post there