Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong marketplaceInfo value being stored in the database #35009

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Jan 22, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CONN-481

Copy link
Contributor

dionisio-bot bot commented Jan 22, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: f93aa2c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Gustrb Gustrb added this to the 7.4.0 milestone Jan 22, 2025
@Gustrb Gustrb requested a review from d-gubert January 22, 2025 19:39
Copy link
Contributor

github-actions bot commented Jan 22, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35009/

Built to branch gh-pages at 2025-01-24 17:24 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (0858ce5) to head (c300b0b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35009   +/-   ##
========================================
  Coverage    59.17%   59.17%           
========================================
  Files         2822     2822           
  Lines        68118    68118           
  Branches     15145    15145           
========================================
  Hits         40312    40312           
  Misses       24975    24975           
  Partials      2831     2831           
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Gustrb Gustrb marked this pull request as ready for review January 22, 2025 20:48
@Gustrb Gustrb requested a review from a team as a code owner January 22, 2025 20:48
@d-gubert d-gubert force-pushed the fix/wrong-marketplaceinfo branch from 0d3180f to 6b083c2 Compare January 22, 2025 23:13
@d-gubert d-gubert marked this pull request as draft January 24, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant