-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: Mentioning users with no messages in room #34997
base: release-7.3.0
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
1402d2c
to
8c3233b
Compare
8c3233b
to
5804fde
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.3.0 #34997 +/- ##
================================================
Coverage ? 59.17%
================================================
Files ? 2821
Lines ? 68131
Branches ? 15152
================================================
Hits ? 40316
Misses ? 24981
Partials ? 2834
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add a test to cover this case?
b663cf6
to
3ed92dc
Compare
Proposed changes (including videos or screenshots)
After a
@tanstack/useQuery
update, one ofuseQueries
wasn't updated to the new version of the library.Issue(s)
Steps to test or reproduce
Further comments
CORE-922