Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Mentioning users with no messages in room #34997

Open
wants to merge 3 commits into
base: release-7.3.0
Choose a base branch
from

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Jan 21, 2025

Proposed changes (including videos or screenshots)

After a @tanstack/useQuery update, one of useQueries wasn't updated to the new version of the library.

Issue(s)

Steps to test or reproduce

Further comments

CORE-922

Copy link
Contributor

dionisio-bot bot commented Jan 21, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: f91c595

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tiagoevanp tiagoevanp force-pushed the regression/composer-box-popup branch from 1402d2c to 8c3233b Compare January 21, 2025 23:25
@tiagoevanp tiagoevanp modified the milestones: 7.4.0, 7.3.0 Jan 21, 2025
@tiagoevanp tiagoevanp changed the base branch from develop to release-7.3.0 January 21, 2025 23:26
@tiagoevanp tiagoevanp force-pushed the regression/composer-box-popup branch from 8c3233b to 5804fde Compare January 21, 2025 23:29
Copy link
Contributor

github-actions bot commented Jan 21, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34997/

Built to branch gh-pages at 2025-01-24 03:58 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.3.0@8731b6d). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.3.0   #34997   +/-   ##
================================================
  Coverage                 ?   59.17%           
================================================
  Files                    ?     2821           
  Lines                    ?    68131           
  Branches                 ?    15152           
================================================
  Hits                     ?    40316           
  Misses                   ?    24981           
  Partials                 ?     2834           
Flag Coverage Δ
unit 74.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo changed the title regression: Tag users with no messages in room regression: Mentioning users with no messages in room Jan 21, 2025
@tiagoevanp tiagoevanp marked this pull request as ready for review January 22, 2025 14:43
@tiagoevanp tiagoevanp requested a review from a team as a code owner January 22, 2025 14:43
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a test to cover this case?

@tiagoevanp tiagoevanp force-pushed the regression/composer-box-popup branch from b663cf6 to 3ed92dc Compare January 24, 2025 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants