Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create mechanism to modify active modules on test mode #33692

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

This PR adds a new endpoint licenses.changeModules (only when Rocket.Chat is running with TEST_MODE enabled);

This endpoint would allow api tests to change the list of enabled license modules on the workspace, so that they may test the behavior with and without certain modules.

An additional requirement to use this endpoint would be that the license include the testModue flag on its meta attribute. The CI license would need to be changed to include this.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 21, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: e3cb8ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33692/
on branch gh-pages at 2024-10-21 17:44 UTC

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 74.95%. Comparing base (5fddfcc) to head (e3cb8ce).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33692      +/-   ##
===========================================
- Coverage    74.97%   74.95%   -0.03%     
===========================================
  Files          480      480              
  Lines        21019    21030      +11     
  Branches      5334     5338       +4     
===========================================
+ Hits         15760    15762       +2     
- Misses        4630     4638       +8     
- Partials       629      630       +1     
Flag Coverage Δ
unit 74.95% <30.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant