feat: apps-engine timeout config #33690
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 6703cbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33690 +/- ##
===========================================
- Coverage 74.97% 74.97% -0.01%
===========================================
Files 480 480
Lines 21019 21021 +2
Branches 5334 5335 +1
===========================================
Hits 15760 15760
- Misses 4630 4632 +2
Partials 629 629
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -53,11 +53,6 @@ export class ProxiedApp { | |||
| public async call(method: `${AppMethod}`, ...args: Array<any>): Promise<any> { | |||
| let options; | |||
|
|
|||
| // Pre events need to be fast as they block the user | |||
| if (method.startsWith('checkPre') || method.startsWith('executePre')) { | |||
There was a problem hiding this comment.
This is probably the only part i don't like. If PRE callbacks block the use, if a user registers a executePreMessageSent that takes the full timeout, it would take 30s by default.
For normal handlers that's good but for these, i wonder if they should have their own env, and maybe a smaller default value.
Proposed changes (including videos or screenshots)
Make the Apps-Engine runtime accept the
APPS_ENGINE_RUNTIME_TIMEOUTenvironment variable to configure the time limit for requests to the Deno subprocess.Also, makes calls to
Preapp event methods follow the same "global" timeout, instead of the shorter 1 second.We've had reports of some environments having timeouts where the request was actually expected to take a longer time to resolve.
Default timeout is increased to 30
Issue(s)
SUP-690
Steps to test or reproduce
Further comments