Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new apps logger deno-runtime #31136

Merged
merged 11 commits into from
Jan 11, 2024
Merged

Conversation

tapiarafael
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Depends on RocketChat/Rocket.Chat.Apps-engine#674

Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: 714c879

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (f35a3f3) 49.46% compared to head (714c879) 53.40%.
Report is 8 commits behind head on feat/apps-deno-runtime.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feat/apps-deno-runtime   #31136      +/-   ##
==========================================================
+ Coverage                   49.46%   53.40%   +3.94%     
==========================================================
  Files                        3312     1491    -1821     
  Lines                       81368    29400   -51968     
  Branches                    16657     5959   -10698     
==========================================================
- Hits                        40249    15702   -24547     
+ Misses                      36415    12586   -23829     
+ Partials                     4704     1112    -3592     
Flag Coverage Δ
e2e 42.54% <67.90%> (-10.33%) ⬇️
e2e-api ?
unit 76.67% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert marked this pull request as ready for review January 11, 2024 20:34
@d-gubert
Copy link
Member

Tests are going to be failing for now, merging it to the feature branch

@d-gubert d-gubert merged commit 4c2bce7 into feat/apps-deno-runtime Jan 11, 2024
26 of 35 checks passed
@d-gubert d-gubert deleted the feat/apps-logger branch January 11, 2024 20:35
d-gubert added a commit that referenced this pull request Jan 30, 2024
* refactor: convert to typescript

* feat: change storeEntries to receive logEntries instead appconsole instance

* refactor: remove `logs-storage.js`

* refactor: remove type `any`

* fix: type errors

* fix: implement correct method

* chore: use apps engine with deno vm

* Fix import

---------

Co-authored-by: Douglas Gubert <[email protected]>
d-gubert added a commit that referenced this pull request Feb 22, 2024
* refactor: convert to typescript

* feat: change storeEntries to receive logEntries instead appconsole instance

* refactor: remove `logs-storage.js`

* refactor: remove type `any`

* fix: type errors

* fix: implement correct method

* chore: use apps engine with deno vm

* Fix import

---------

Co-authored-by: Douglas Gubert <[email protected]>
d-gubert added a commit that referenced this pull request Mar 14, 2024
* refactor: convert to typescript

* feat: change storeEntries to receive logEntries instead appconsole instance

* refactor: remove `logs-storage.js`

* refactor: remove type `any`

* fix: type errors

* fix: implement correct method

* chore: use apps engine with deno vm

* Fix import

---------

Co-authored-by: Douglas Gubert <[email protected]>
d-gubert added a commit that referenced this pull request Mar 16, 2024
* refactor: convert to typescript

* feat: change storeEntries to receive logEntries instead appconsole instance

* refactor: remove `logs-storage.js`

* refactor: remove type `any`

* fix: type errors

* fix: implement correct method

* chore: use apps engine with deno vm

* Fix import

---------

Co-authored-by: Douglas Gubert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants