chore: Improve system messages for omni-visitor abandonment feature

[murtaza98]

Proposed changes (including videos or screenshots)

Visitor abandonment feature used to rely on room.v.lastMessageTs property to calculate the predicted time when the chat should be considered abandoned. Now when apps were updating the room properties like customFields, then the app converters were overriding lastMessageTs property ( reference ), thus making this abandonment feature not work for rooms created from apps.
So to solve this, I've moved the lastMessageTs prop out of room.v, and instead I'm storing it as room.contactLastMessageTs. This will prevent the app's engine to override this prop, thus fixing the main issue due to which app's room were not being abandoned automatically.

Update: This PR has been updated to now only include changes to system messages related to visitor abandonment feature. The rest of the changes wrt visitor abandonment feature not working has been moved to a separate PR here -> #29756

Issue(s)

Steps to test or reproduce

Further comments

[changeset-bot]

🦋 Changeset detected

Latest commit: 184a31c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/models	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

Merging #29724 (184a31c) into develop (1246a21) will increase coverage by 1.45%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #29724      +/-   ##
===========================================
+ Coverage    45.35%   46.81%   +1.45%     
===========================================
  Files          671      690      +19     
  Lines        12833    12981     +148     
  Branches      2236     2267      +31     
===========================================
+ Hits          5821     6077     +256     
+ Misses        6687     6572     -115     
- Partials       325      332       +7     

Flag	Coverage Δ
e2e	46.79% <ø> (+1.45%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[KevLehman]

What about compatibility with old rooms that have v.lastMessage? Since we're changing the property where we take info, we do need to make sure we keep compatibility with them.

Or we can create a single shot function that moves v.lastMessage to contactLastMessage

[sampaiodiego]

if you were able to pin point the problem root (

Rocket.Chat/apps/meteor/app/apps/server/converters/rooms.js

Line 41 in 74aa677

v = {

), why not fixing the code only there? I mean, all these changes are just an alternative solution, but it doesn't fix the root cause of the problem, right?

[ggazzo]

Great explanation @murtaza98, but I would like to enforce: on patches keep your changes small as possible, if you are fixing something focus on the fix, if you are refactoring something try to refactor without change any behavior, if you are creating something new, avoid fixes and code changes that dont are directly related with the new feature

about your change in specific I think its only about change the bridge as you mentioned. that would be a great fix (2..3 lines of code)

if you are planning to replace some field or optimize any message let this to another pull request