-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Improve Omnichannel queries #29711
Conversation
|
Codecov Report
@@ Coverage Diff @@
## develop #29711 +/- ##
===========================================
- Coverage 50.37% 50.37% -0.01%
===========================================
Files 747 745 -2
Lines 14431 14400 -31
Branches 2581 2578 -3
===========================================
- Hits 7270 7254 -16
+ Misses 6773 6758 -15
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great! 👏 thx a lot! 🤗
just one overall comment, I think when using projection
it is important to provide the correct returning type using generics.. otherwise TS will always return the full document, which can cause even more issues.
I know the generic is already there for findOneById<T>(...)
, so for places using it it would be just a matter of providing the returning type.. but for the new methods you'd need to add the generics too.
c255bfa
to
3ab6895
Compare
3ab6895
to
4993200
Compare
Proposed changes (including videos or screenshots)
fields
forprojection
projection
for places where we aren't using the full objIssue(s)
Steps to test or reproduce
Further comments