Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove enforce password fallback dependency #29634

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Jun 23, 2023

Proposed changes (including videos or screenshots)

Allow to reset user E2E key and TOTP even if the setting Enforce Password Fallback is disabled.

Issue(s)

Steps to test or reproduce

Further comments

SUP-29

@tapiarafael tapiarafael requested a review from a team as a code owner June 23, 2023 14:05
@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2023

🦋 Changeset detected

Latest commit: 7978eaa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #29634 (7978eaa) into develop (b011c17) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29634      +/-   ##
===========================================
+ Coverage    46.55%   46.71%   +0.16%     
===========================================
  Files          673      673              
  Lines        12879    12879              
  Branches      2248     2248              
===========================================
+ Hits          5996     6017      +21     
+ Misses        6553     6533      -20     
+ Partials       330      329       -1     
Flag Coverage Δ
e2e 46.68% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@casalsgh casalsgh requested review from hugocostadev and a team June 26, 2023 12:41
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 12, 2023
@casalsgh casalsgh added the squad: Workspace Management squad: Workspace Management label Jul 12, 2023
@casalsgh casalsgh added this to the 6.4.0 milestone Jul 12, 2023
@casalsgh casalsgh requested review from a team and removed request for a team July 24, 2023 11:56
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jul 24, 2023
@kodiakhq kodiakhq bot merged commit 85a9362 into develop Jul 24, 2023
37 checks passed
@kodiakhq kodiakhq bot deleted the feat/remove-password-fallback-dependency branch July 24, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: Workspace Management squad: Workspace Management stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants