Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Rendering issue with codeblock and attachment combination #5998

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Rohit3523
Copy link
Contributor

Proposed changes

This PR addresses an issue where sending a codeblock with an attachment caused improper rendering. The root cause was the library appending an extra newline \n at the end of the string, which shows an unwanted blank line, resulting in a layout that differed from a standard codeblock.
Additionally, I have added a marginBottom to create a small gap between the attachment and codeblock

Issue(s)

None

How to test or reproduce

Send an attachment with codeblock

Screenshots

Before After
Screenshot 2024-11-15 at 1 36 43 PM Screenshot 2024-11-15 at 1 37 13 PM

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the point on this issue.
image

See how both codeblock markdowns on the image are the same, but with different text styles?
That's what we're trying to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants