Feature: Expo image #5996
Open
Feature: Expo image #5996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rohit3523
commented
Nov 14, 2024
| @@ -36,7 +36,7 @@ | |||
|
|
|||
| import com.reactnativecommunity.webview.RNCWebViewManager; | |||
|
|
|||
| import com.dylanvann.fastimage.FastImageOkHttpUrlLoader; | |||
| // import com.dylanvann.fastimage.FastImageOkHttpUrlLoader; | |||
I don't know how can i remove these from the gemfile, never deal with this in react-native ;-; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR removes the
react-native-fast-imagepackage and replaces it withexpo-imagefor handling image rendering in the app. The main reason for this change is to simplify the image loading process while ensuring better compatibility with Expo-managed workflows. By switching toexpo-image, we align the app more closely with Expo's ecosystem, reducing the need for third-party dependencies that are not part of Expo. All instances ofFastImagehave been updated to useexpo-image, but the change should not introduce any breaking changes as the API ofexpo-imageis quite similar.Issue(s)
None
Types of changes
Bugfix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves a current function)
New feature (non-breaking change which adds functionality)
Documentation update (if none of the other choices apply)
I have read the CONTRIBUTING doc
I have signed the CLA
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if applicable)
I have added necessary documentation (if applicable)
Any dependent changes have been merged and published in downstream modules