Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added pagination on sync.messages #5992

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

chore: added pagination on sync.messages #5992

wants to merge 5 commits into from
+110 −28

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Nov 14, 2024 •
edited by diegolmello
Loading

Proposed changes

Apply pagination based on RocketChat/Rocket.Chat#33810

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-787

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak marked this pull request as ready for review November 19, 2024 22:58
@diegolmello diegolmello changed the title chore: added pagination on sync.mesages chore: added pagination on sync.messages Nov 22, 2024
diegolmello
diegolmello requested changes Nov 22, 2024
View reviewed changes
app/lib/methods/loadMissedMessages.ts Outdated Show resolved Hide resolved
app/lib/methods/loadMissedMessages.ts Outdated Show resolved Hide resolved
app/lib/methods/loadMissedMessages.ts Outdated Show resolved Hide resolved
app/lib/methods/loadMissedMessages.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello diegolmello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OtavioStasiak @diegolmello